Merge branch 'develop' into kill-led-builtin

2025-12-27 05:00:38 +00:00 · 2025-12-26 15:26:29 -06:00 · 2025-12-21 23:23:45 -06:00 · 2025-12-09 23:20:19 -06:00 · 2025-12-08 17:16:10 -06:00 · 2025-12-08 17:14:43 -06:00
80 changed files with 17 additions and 382 deletions
--- a/.github/workflows/main_matrix.yml
+++ b/.github/workflows/main_matrix.yml
@@ -240,7 +240,6 @@ jobs:
    needs: [build]
    steps:
      - uses: actions/checkout@v6
-        if: github.event_name == 'pull_request_target'
        with:
          filter: blob:none # means we download all the git history but none of the commit (except ones with checkout like the head)
          fetch-depth: 0
@@ -254,20 +253,18 @@ jobs:
        uses: actions/upload-artifact@v6
        id: upload-manifest
        with:
-          name: manifests-${{ github.sha }}
+          name: manifests-all
          overwrite: true
-          path: manifests-new/*.mt.json
+          path: |
+            manifests-new/*.mt.json
      - name: Find the merge base
-        if: github.event_name == 'pull_request_target'
        run: echo "MERGE_BASE=$(git merge-base "origin/$base" "$head")" >> $GITHUB_ENV
        env:
          base: ${{ github.base_ref }}
-          head: ${{ github.sha }}
+          head: ${{ github.head_ref }}
      - name: Download the old manifests
-        if: github.event_name == 'pull_request_target'
-        run: gh run download -R ${{ github.repository }} --name manifests-${{ env.MERGE_BASE }} --dir manifest-old/
+        run: gh run download -R ${{ github.repository }} --commit ${{ env.MERGE_BASE }} --name manifests-all --dir manifest-old/
      - name: Do scan and post comment
-        if: github.event_name == 'pull_request_target'
        run: python3 bin/shame.py ${{ github.event.pull_request.number }} manifests-old/ manifests-new/

  release-artifacts:
--- a/platformio.ini
+++ b/platformio.ini
@@ -55,6 +55,7 @@ build_flags = -Wno-missing-field-initializers
 	-DMESHTASTIC_EXCLUDE_POWERSTRESS=1 ; exclude power stress test module from main firmware
 	-DMESHTASTIC_EXCLUDE_GENERIC_THREAD_MODULE=1
 	-D MAX_THREADS=40 ; As we've split modules, we have more threads to manage
+	-DLED_BUILTIN=-1
 	#-DBUILD_EPOCH=$UNIX_TIME ; set in platformio-custom.py now
 	#-D OLED_PL=1
 	#-D DEBUG_HEAP=1 ; uncomment to add free heap space / memory leak debugging logs
--- a/src/graphics/draw/MenuHandler.cpp
+++ b/src/graphics/draw/MenuHandler.cpp
@@ -1092,23 +1092,11 @@ void menuHandler::favoriteBaseMenu()

 void menuHandler::positionBaseMenu()
 {
-    enum optionsNumbers {
-        Back,
-        GPSToggle,
-        GPSFormat,
-        CompassMenu,
-        CompassCalibrate,
-        GPSSmartPosition,
-        GPSUpdateInterval,
-        GPSPositionBroadcast,
-        enumEnd
-    };
+    enum optionsNumbers { Back, GPSToggle, GPSFormat, CompassMenu, CompassCalibrate, enumEnd };

-    static const char *optionsArray[enumEnd] = {
-        "Back", "On/Off Toggle", "Format", "Smart Position", "Update Interval", "Broadcast Interval", "Compass"};
-    static int optionsEnumArray[enumEnd] = {
-        Back, GPSToggle, GPSFormat, GPSSmartPosition, GPSUpdateInterval, GPSPositionBroadcast, CompassMenu};
-    int options = 7;
+    static const char *optionsArray[enumEnd] = {"Back", "GPS Toggle", "GPS Format", "Compass"};
+    static int optionsEnumArray[enumEnd] = {Back, GPSToggle, GPSFormat, CompassMenu};
+    int options = 4;

    if (accelerometerThread) {
        optionsArray[options] = "Compass Calibrate";
@@ -1116,7 +1104,7 @@ void menuHandler::positionBaseMenu()
    }

    BannerOverlayOptions bannerOptions;
-    bannerOptions.message = "GPS Action";
+    bannerOptions.message = "Position Action";
    bannerOptions.optionsArrayPtr = optionsArray;
    bannerOptions.optionsEnumPtr = optionsEnumArray;
    bannerOptions.optionsCount = options;
@@ -1132,15 +1120,6 @@ void menuHandler::positionBaseMenu()
            screen->runNow();
        } else if (selected == CompassCalibrate) {
            accelerometerThread->calibrate(30);
-        } else if (selected == GPSSmartPosition) {
-            menuQueue = gps_smart_position_menu;
-            screen->runNow();
-        } else if (selected == GPSUpdateInterval) {
-            menuQueue = gps_update_interval_menu;
-            screen->runNow();
-        } else if (selected == GPSPositionBroadcast) {
-            menuQueue = gps_position_broadcast_menu;
-            screen->runNow();
        }
    };
    screen->showOverlayBanner(bannerOptions);
@@ -1367,203 +1346,6 @@ void menuHandler::GPSFormatMenu()
    bannerOptions.InitialSelected = uiconfig.gps_format + 1;
    screen->showOverlayBanner(bannerOptions);
 }
-
-void menuHandler::GPSSmartPositionMenu()
-{
-    static const char *optionsArray[] = {"Back", "Enabled", "Disabled"};
-    BannerOverlayOptions bannerOptions;
-    bannerOptions.message = "Toggle Smart Position";
-    if (currentResolution == ScreenResolution::UltraLow) {
-        bannerOptions.message = "Smrt Postn";
-    }
-    bannerOptions.optionsArrayPtr = optionsArray;
-    bannerOptions.optionsCount = 3;
-    bannerOptions.bannerCallback = [](int selected) -> void {
-        if (selected == 0) {
-            menuQueue = position_base_menu;
-            screen->runNow();
-        } else if (selected == 1) {
-            config.position.position_broadcast_smart_enabled = true;
-            saveUIConfig();
-            service->reloadConfig(SEGMENT_CONFIG);
-            rebootAtMsec = (millis() + DEFAULT_REBOOT_SECONDS * 1000);
-        } else if (selected == 2) {
-            config.position.position_broadcast_smart_enabled = false;
-            saveUIConfig();
-            service->reloadConfig(SEGMENT_CONFIG);
-            rebootAtMsec = (millis() + DEFAULT_REBOOT_SECONDS * 1000);
-        }
-    };
-    bannerOptions.InitialSelected = config.position.position_broadcast_smart_enabled ? 1 : 2;
-    screen->showOverlayBanner(bannerOptions);
-}
-
-void menuHandler::GPSUpdateIntervalMenu()
-{
-    static const char *optionsArray[] = {"Back",      "8 seconds", "20 seconds", "40 seconds",  "1 minute",   "80 seconds",
-                                         "2 minutes", "5 minutes", "10 minutes", "15 minutes",  "30 minutes", "1 hour",
-                                         "6 hours",   "12 hours",  "24 hours",   "At Boot Only"};
-    BannerOverlayOptions bannerOptions;
-    bannerOptions.message = "Update Interval";
-    bannerOptions.optionsArrayPtr = optionsArray;
-    bannerOptions.optionsCount = 16;
-    bannerOptions.bannerCallback = [](int selected) -> void {
-        if (selected == 0) {
-            menuQueue = position_base_menu;
-            screen->runNow();
-        } else if (selected == 1) {
-            config.position.gps_update_interval = 8;
-        } else if (selected == 2) {
-            config.position.gps_update_interval = 20;
-        } else if (selected == 3) {
-            config.position.gps_update_interval = 40;
-        } else if (selected == 4) {
-            config.position.gps_update_interval = 60;
-        } else if (selected == 5) {
-            config.position.gps_update_interval = 80;
-        } else if (selected == 6) {
-            config.position.gps_update_interval = 120;
-        } else if (selected == 7) {
-            config.position.gps_update_interval = 300;
-        } else if (selected == 8) {
-            config.position.gps_update_interval = 600;
-        } else if (selected == 9) {
-            config.position.gps_update_interval = 900;
-        } else if (selected == 10) {
-            config.position.gps_update_interval = 1800;
-        } else if (selected == 11) {
-            config.position.gps_update_interval = 3600;
-        } else if (selected == 12) {
-            config.position.gps_update_interval = 21600;
-        } else if (selected == 13) {
-            config.position.gps_update_interval = 43200;
-        } else if (selected == 14) {
-            config.position.gps_update_interval = 86400;
-        } else if (selected == 15) {
-            config.position.gps_update_interval = 2147483647; // At Boot Only
-        }
-
-        if (selected != 0) {
-            saveUIConfig();
-            service->reloadConfig(SEGMENT_CONFIG);
-            rebootAtMsec = (millis() + DEFAULT_REBOOT_SECONDS * 1000);
-        }
-    };
-
-    if (config.position.gps_update_interval == 30) {
-        bannerOptions.InitialSelected = 1;
-    } else if (config.position.gps_update_interval == 60) {
-        bannerOptions.InitialSelected = 2;
-    } else if (config.position.gps_update_interval == 120) {
-        bannerOptions.InitialSelected = 3;
-    } else if (config.position.gps_update_interval == 300) {
-        bannerOptions.InitialSelected = 4;
-    } else if (config.position.gps_update_interval == 600) {
-        bannerOptions.InitialSelected = 5;
-    } else if (config.position.gps_update_interval == 900) {
-        bannerOptions.InitialSelected = 6;
-    } else if (config.position.gps_update_interval == 1800) {
-        bannerOptions.InitialSelected = 7;
-    } else if (config.position.gps_update_interval == 3600) {
-        bannerOptions.InitialSelected = 8;
-    } else if (config.position.gps_update_interval == 21600) {
-        bannerOptions.InitialSelected = 9;
-    } else if (config.position.gps_update_interval == 43200) {
-        bannerOptions.InitialSelected = 10;
-    } else if (config.position.gps_update_interval == 86400) {
-        bannerOptions.InitialSelected = 11;
-    } else if (config.position.gps_update_interval == 2147483647) { // At Boot Only
-        bannerOptions.InitialSelected = 12;
-    } else {
-        bannerOptions.InitialSelected = 0;
-    }
-    screen->showOverlayBanner(bannerOptions);
-}
-
-void menuHandler::GPSPositionBroadcastMenu()
-{
-    static const char *optionsArray[] = {"Back",     "1 minute", "90 seconds", "5 minutes", "15 minutes", "1 hour",
-                                         "2 hours",  "3 hours",  "4 hours",    "5 hours",   "6 hours",    "12 hours",
-                                         "18 hours", "24 hours", "36 hours",   "48 hours",  "72 hours"};
-    BannerOverlayOptions bannerOptions;
-    bannerOptions.message = "Broadcast Interval";
-    bannerOptions.optionsArrayPtr = optionsArray;
-    bannerOptions.optionsCount = 17;
-    bannerOptions.bannerCallback = [](int selected) -> void {
-        if (selected == 0) {
-            menuQueue = position_base_menu;
-            screen->runNow();
-        } else if (selected == 1) {
-            config.position.position_broadcast_secs = 60;
-        } else if (selected == 2) {
-            config.position.position_broadcast_secs = 90;
-        } else if (selected == 3) {
-            config.position.position_broadcast_secs = 300;
-        } else if (selected == 4) {
-            config.position.position_broadcast_secs = 900;
-        } else if (selected == 5) {
-            config.position.position_broadcast_secs = 3600;
-        } else if (selected == 6) {
-            config.position.position_broadcast_secs = 7200;
-        } else if (selected == 7) {
-            config.position.position_broadcast_secs = 10800;
-        } else if (selected == 8) {
-            config.position.position_broadcast_secs = 14400;
-        } else if (selected == 9) {
-            config.position.position_broadcast_secs = 18000;
-        } else if (selected == 10) {
-            config.position.position_broadcast_secs = 21600;
-        } else if (selected == 11) {
-            config.position.position_broadcast_secs = 43200;
-        } else if (selected == 12) {
-            config.position.position_broadcast_secs = 64800;
-        } else if (selected == 13) {
-            config.position.position_broadcast_secs = 86400;
-        } else if (selected == 14) {
-            config.position.position_broadcast_secs = 129600;
-        } else if (selected == 15) {
-            config.position.position_broadcast_secs = 172800;
-        } else if (selected == 16) {
-            config.position.position_broadcast_secs = 259200;
-        }
-
-        if (selected != 0) {
-            saveUIConfig();
-            service->reloadConfig(SEGMENT_CONFIG);
-            rebootAtMsec = (millis() + DEFAULT_REBOOT_SECONDS * 1000);
-        }
-    };
-
-    if (config.position.position_broadcast_secs == 3600) {
-        bannerOptions.InitialSelected = 1;
-    } else if (config.position.position_broadcast_secs == 7200) {
-        bannerOptions.InitialSelected = 2;
-    } else if (config.position.position_broadcast_secs == 10800) {
-        bannerOptions.InitialSelected = 3;
-    } else if (config.position.position_broadcast_secs == 14400) {
-        bannerOptions.InitialSelected = 4;
-    } else if (config.position.position_broadcast_secs == 18000) {
-        bannerOptions.InitialSelected = 5;
-    } else if (config.position.position_broadcast_secs == 21600) {
-        bannerOptions.InitialSelected = 6;
-    } else if (config.position.position_broadcast_secs == 43200) {
-        bannerOptions.InitialSelected = 7;
-    } else if (config.position.position_broadcast_secs == 64800) {
-        bannerOptions.InitialSelected = 8;
-    } else if (config.position.position_broadcast_secs == 86400) {
-        bannerOptions.InitialSelected = 9;
-    } else if (config.position.position_broadcast_secs == 129600) {
-        bannerOptions.InitialSelected = 10;
-    } else if (config.position.position_broadcast_secs == 172800) {
-        bannerOptions.InitialSelected = 11;
-    } else if (config.position.position_broadcast_secs == 259200) {
-        bannerOptions.InitialSelected = 12;
-    } else {
-        bannerOptions.InitialSelected = 0;
-    }
-    screen->showOverlayBanner(bannerOptions);
-}
-
 #endif

 void menuHandler::BluetoothToggleMenu()
@@ -2344,15 +2126,6 @@ void menuHandler::handleMenuSwitch(OLEDDisplay *display)
    case gps_format_menu:
        GPSFormatMenu();
        break;
-    case gps_smart_position_menu:
-        GPSSmartPositionMenu();
-        break;
-    case gps_update_interval_menu:
-        GPSUpdateIntervalMenu();
-        break;
-    case gps_position_broadcast_menu:
-        GPSPositionBroadcastMenu();
-        break;
 #endif
    case compass_point_north_menu:
        compassNorthMenu();
--- a/src/graphics/draw/MenuHandler.h
+++ b/src/graphics/draw/MenuHandler.h
@@ -22,9 +22,6 @@ class menuHandler
        node_base_menu,
        gps_toggle_menu,
        gps_format_menu,
-        gps_smart_position_menu,
-        gps_update_interval_menu,
-        gps_position_broadcast_menu,
        compass_point_north_menu,
        reset_node_db_menu,
        buzzermodemenupicker,
@@ -80,9 +77,6 @@ class menuHandler
    static void compassNorthMenu();
    static void GPSToggleMenu();
    static void GPSFormatMenu();
-    static void GPSSmartPositionMenu();
-    static void GPSUpdateIntervalMenu();
-    static void GPSPositionBroadcastMenu();
    static void BuzzerModeMenu();
    static void switchToMUIMenu();
    static void TFTColorPickerMenu(OLEDDisplay *display);
--- a/src/modules/PositionModule.h
+++ b/src/modules/PositionModule.h
@@ -69,7 +69,7 @@ class PositionModule : public ProtobufModule<meshtastic_Position>, private concu
    // In event mode we want to prevent excessive position broadcasts
    // we set the minimum interval to 5m
    const uint32_t minimumTimeThreshold =
-        max(uint32_t(300000), Default::getConfiguredOrDefaultMs(config.position.broadcast_smart_minimum_interval_secs, 30));
+        max(300000, Default::getConfiguredOrDefaultMs(config.position.broadcast_smart_minimum_interval_secs, 30));
 #else
    const uint32_t minimumTimeThreshold =
        Default::getConfiguredOrDefaultMs(config.position.broadcast_smart_minimum_interval_secs, 30);
--- a/variants/esp32/rak11200/pins_arduino.h
+++ b/variants/esp32/rak11200/pins_arduino.h
@@ -6,8 +6,6 @@
 #define LED_GREEN 12
 #define LED_BLUE 2

-#define LED_BUILTIN LED_GREEN
-
 static const uint8_t TX = 1;
 static const uint8_t RX = 3;

--- a/variants/esp32/rak11200/variant.h
+++ b/variants/esp32/rak11200/variant.h
@@ -6,8 +6,6 @@
 #define LED_GREEN 12
 #define LED_BLUE 2

-#define LED_BUILTIN LED_GREEN
-
 static const uint8_t TX = 1;
 static const uint8_t RX = 3;

--- a/variants/esp32/tbeam/platformio.ini
+++ b/variants/esp32/tbeam/platformio.ini
@@ -9,6 +9,7 @@ build_flags = ${esp32_base.build_flags}
  -I variants/esp32/tbeam
  -DBOARD_HAS_PSRAM
  -mfix-esp32-psram-cache-issue
+  -ULED_BUILTIN
 upload_speed = 921600

 [env:tbeam-displayshield]
--- a/variants/esp32c6/tlora_c6/platformio.ini
+++ b/variants/esp32c6/tlora_c6/platformio.ini
@@ -8,3 +8,4 @@ build_flags =
  -I variants/esp32c6/tlora_c6
  -DARDUINO_USB_CDC_ON_BOOT=1
  -DARDUINO_USB_MODE=1
+  -ULED_BUILTIN
--- a/variants/esp32s3/heltec_v3/platformio.ini
+++ b/variants/esp32s3/heltec_v3/platformio.ini
@@ -8,3 +8,4 @@ build_flags =
  ${esp32s3_base.build_flags}
  -D HELTEC_V3
  -I variants/esp32s3/heltec_v3
+  -ULED_BUILTIN
--- a/variants/esp32s3/heltec_v4/pins_arduino.h
+++ b/variants/esp32s3/heltec_v4/pins_arduino.h
@@ -6,10 +6,6 @@
 #define USB_VID 0x303a
 #define USB_PID 0x1001

-static const uint8_t LED_BUILTIN = 35;
-#define BUILTIN_LED LED_BUILTIN // backward compatibility
-#define LED_BUILTIN LED_BUILTIN // allow testing #ifdef LED_BUILTIN
-
 static const uint8_t TX = 43;
 static const uint8_t RX = 44;

--- a/variants/esp32s3/heltec_vision_master_e213/pins_arduino.h
+++ b/variants/esp32s3/heltec_vision_master_e213/pins_arduino.h
@@ -3,10 +3,6 @@

 #include <stdint.h>

-static const uint8_t LED_BUILTIN = 45; // LED is not populated on earliest board variant
-#define BUILTIN_LED LED_BUILTIN        // Backward compatibility
-#define LED_BUILTIN LED_BUILTIN
-
 static const uint8_t TX = 43;
 static const uint8_t RX = 44;

--- a/variants/esp32s3/heltec_vision_master_e290/pins_arduino.h
+++ b/variants/esp32s3/heltec_vision_master_e290/pins_arduino.h
@@ -3,10 +3,6 @@

 #include <stdint.h>

-static const uint8_t LED_BUILTIN = 45; // LED is not populated on earliest board variant
-#define BUILTIN_LED LED_BUILTIN        // Backward compatibility
-#define LED_BUILTIN LED_BUILTIN
-
 static const uint8_t TX = 43;
 static const uint8_t RX = 44;

--- a/variants/esp32s3/heltec_vision_master_t190/pins_arduino.h
+++ b/variants/esp32s3/heltec_vision_master_t190/pins_arduino.h
@@ -3,10 +3,6 @@

 #include <stdint.h>

-static const uint8_t LED_BUILTIN = 35;
-#define BUILTIN_LED LED_BUILTIN // backward compatibility
-#define LED_BUILTIN LED_BUILTIN
-
 static const uint8_t TX = 43;
 static const uint8_t RX = 44;

--- a/variants/esp32s3/heltec_wireless_paper/pins_arduino.h
+++ b/variants/esp32s3/heltec_wireless_paper/pins_arduino.h
@@ -3,10 +3,6 @@

 #include <stdint.h>

-static const uint8_t LED_BUILTIN = 18;
-#define BUILTIN_LED LED_BUILTIN // backward compatibility
-#define LED_BUILTIN LED_BUILTIN
-
 static const uint8_t TX = 43;
 static const uint8_t RX = 44;

--- a/variants/esp32s3/heltec_wireless_paper_v1/pins_arduino.h
+++ b/variants/esp32s3/heltec_wireless_paper_v1/pins_arduino.h
@@ -3,10 +3,6 @@

 #include <stdint.h>

-static const uint8_t LED_BUILTIN = 18;
-#define BUILTIN_LED LED_BUILTIN // backward compatibility
-#define LED_BUILTIN LED_BUILTIN
-
 static const uint8_t KEY_BUILTIN = 0;

 static const uint8_t TX = 43;
--- a/variants/esp32s3/heltec_wireless_tracker/pins_arduino.h
+++ b/variants/esp32s3/heltec_wireless_tracker/pins_arduino.h
@@ -11,10 +11,6 @@
 #define USB_VID 0x303a
 #define USB_PID 0x1001

-static const uint8_t LED_BUILTIN = 18;
-#define BUILTIN_LED LED_BUILTIN // backward compatibility
-#define LED_BUILTIN LED_BUILTIN
-
 static const uint8_t TX = 43;
 static const uint8_t RX = 44;

--- a/variants/esp32s3/heltec_wireless_tracker_V1_0/pins_arduino.h
+++ b/variants/esp32s3/heltec_wireless_tracker_V1_0/pins_arduino.h
@@ -11,10 +11,6 @@
 #define USB_VID 0x303a
 #define USB_PID 0x1001

-static const uint8_t LED_BUILTIN = 18;
-#define BUILTIN_LED LED_BUILTIN // backward compatibility
-#define LED_BUILTIN LED_BUILTIN
-
 static const uint8_t TX = 43;
 static const uint8_t RX = 44;

--- a/variants/esp32s3/heltec_wireless_tracker_v2/pins_arduino.h
+++ b/variants/esp32s3/heltec_wireless_tracker_v2/pins_arduino.h
@@ -10,10 +10,6 @@
 #define USB_VID 0x303a
 #define USB_PID 0x1001

-static const uint8_t LED_BUILTIN = 18;
-#define BUILTIN_LED LED_BUILTIN // backward compatibility
-#define LED_BUILTIN LED_BUILTIN
-
 static const uint8_t TX = 43;
 static const uint8_t RX = 44;

--- a/variants/esp32s3/m5stack_cores3/pins_arduino.h
+++ b/variants/esp32s3/m5stack_cores3/pins_arduino.h
@@ -10,10 +10,7 @@
 // Some boards have too low voltage on this pin (board design bug)
 // Use different pin with 3V and connect with 48
 // and change this setup for the chosen pin (for example 38)
-static const uint8_t LED_BUILTIN = SOC_GPIO_PIN_COUNT + 48;
-#define BUILTIN_LED LED_BUILTIN // backward compatibility
-#define LED_BUILTIN LED_BUILTIN
-#define RGB_BUILTIN LED_BUILTIN
+#define RGB_BUILTIN SOC_GPIO_PIN_COUNT + 48
 #define RGB_BRIGHTNESS 64

 static const uint8_t TX = 43;
--- a/variants/esp32s3/mesh-tab/pins_arduino.h
+++ b/variants/esp32s3/mesh-tab/pins_arduino.h
@@ -49,10 +49,6 @@ static const uint8_t T14 = 14;
 static const uint8_t VBAT_SENSE = 2;
 static const uint8_t VBUS_SENSE = 34;

-// User LED
-#define LED_BUILTIN 13
-#define BUILTIN_LED LED_BUILTIN // backward compatibility
-
 static const uint8_t RGB_DATA = 40;
 // RGB_BUILTIN and RGB_BRIGHTNESS can be used in new Arduino API neopixelWrite()
 #define RGB_BUILTIN (RGB_DATA + SOC_GPIO_PIN_COUNT)
--- a/variants/esp32s3/rak3312/pins_arduino.h
+++ b/variants/esp32s3/rak3312/pins_arduino.h
@@ -22,7 +22,4 @@ static const uint8_t SCK = 13;
 #define SPI_MISO (10)
 #define SPI_CS (12)

-// LEDs
-#define LED_BUILTIN LED_GREEN
-
 #endif /* Pins_Arduino_h */
--- a/variants/esp32s3/rak_wismesh_tap_v2/pins_arduino.h
+++ b/variants/esp32s3/rak_wismesh_tap_v2/pins_arduino.h
@@ -22,7 +22,4 @@ static const uint8_t SCK = 13;
 #define SPI_MISO (10)
 #define SPI_CS (12)

-// LEDs
-#define LED_BUILTIN LED_GREEN
-
 #endif /* Pins_Arduino_h */
--- a/variants/esp32s3/seeed-sensecap-indicator/pins_arduino.h
+++ b/variants/esp32s3/seeed-sensecap-indicator/pins_arduino.h
@@ -3,8 +3,6 @@

 #include <stdint.h>

-// static const uint8_t LED_BUILTIN = -1;
-
 // static const uint8_t TX = 43;
 // static const uint8_t RX = 44;

--- a/variants/esp32s3/t-deck/pins_arduino.h
+++ b/variants/esp32s3/t-deck/pins_arduino.h
@@ -6,8 +6,6 @@
 #define USB_VID 0x303a
 #define USB_PID 0x1001

-// static const uint8_t LED_BUILTIN = -1;
-
 static const uint8_t TX = 43;
 static const uint8_t RX = 44;

--- a/variants/esp32s3/t-watch-s3/pins_arduino.h
+++ b/variants/esp32s3/t-watch-s3/pins_arduino.h
@@ -3,8 +3,6 @@

 #include <stdint.h>

-// static const uint8_t LED_BUILTIN = -1;
-
 // static const uint8_t TX = 43;
 // static const uint8_t RX = 44;

--- a/variants/esp32s3/tracksenger/internal/pins_arduino.h
+++ b/variants/esp32s3/tracksenger/internal/pins_arduino.h
@@ -11,10 +11,6 @@
 #define USB_VID 0x303a
 #define USB_PID 0x1001

-static const uint8_t LED_BUILTIN = 18;
-#define BUILTIN_LED LED_BUILTIN // backward compatibility
-#define LED_BUILTIN LED_BUILTIN
-
 static const uint8_t TX = 43;
 static const uint8_t RX = 44;

--- a/variants/esp32s3/tracksenger/lcd/pins_arduino.h
+++ b/variants/esp32s3/tracksenger/lcd/pins_arduino.h
@@ -11,10 +11,6 @@
 #define USB_VID 0x303a
 #define USB_PID 0x1001

-static const uint8_t LED_BUILTIN = 18;
-#define BUILTIN_LED LED_BUILTIN // backward compatibility
-#define LED_BUILTIN LED_BUILTIN
-
 static const uint8_t TX = 43;
 static const uint8_t RX = 44;

--- a/variants/esp32s3/tracksenger/oled/pins_arduino.h
+++ b/variants/esp32s3/tracksenger/oled/pins_arduino.h
@@ -11,10 +11,6 @@
 #define USB_VID 0x303a
 #define USB_PID 0x1001

-static const uint8_t LED_BUILTIN = 18;
-#define BUILTIN_LED LED_BUILTIN // backward compatibility
-#define LED_BUILTIN LED_BUILTIN
-
 static const uint8_t TX = 43;
 static const uint8_t RX = 44;

--- a/variants/esp32s3/unphone/pins_arduino.h
+++ b/variants/esp32s3/unphone/pins_arduino.h
@@ -6,9 +6,6 @@
 #define USB_VID 0x16D0
 #define USB_PID 0x1178

-#define LED_BUILTIN 13
-#define BUILTIN_LED LED_BUILTIN // backward compatibility
-
 static const uint8_t TX = 43;
 static const uint8_t RX = 44;

--- a/variants/nrf52840/Dongle_nRF52840-pca10059-v1/variant.h
+++ b/variants/nrf52840/Dongle_nRF52840-pca10059-v1/variant.h
@@ -50,7 +50,6 @@ extern "C" {
 #define RGBLED_BLUE (0 + 12)  // Blue of RGB   P0.12
 #define RGBLED_CA             // comment out this line if you have a common cathode type, as defined use common anode logic

-#define LED_BUILTIN PIN_LED1
 #define LED_CONN PIN_LED2

 #define LED_GREEN PIN_LED1
--- a/variants/nrf52840/ELECROW-ThinkNode-M1/variant.h
+++ b/variants/nrf52840/ELECROW-ThinkNode-M1/variant.h
@@ -55,7 +55,6 @@ extern "C" {
 #define LED_RED PIN_LED3
 #define LED_BLUE PIN_LED1
 #define LED_GREEN PIN_LED2
-#define LED_BUILTIN LED_BLUE
 #define LED_CONN PIN_GREEN
 #define LED_STATE_ON 0 // State when LED is lit  // LED灯亮时的状态
 #define PIN_BUZZER (0 + 6)
--- a/variants/nrf52840/ELECROW-ThinkNode-M3/variant.h
+++ b/variants/nrf52840/ELECROW-ThinkNode-M3/variant.h
@@ -58,7 +58,6 @@ extern "C" {
 #define LED_BLUE 37
 #define LED_PAIRING LED_BLUE // Signals the Status LED Module to handle this LED

-#define LED_BUILTIN -1
 #define LED_STATE_ON LOW
 #define LED_STATE_OFF HIGH

--- a/variants/nrf52840/ELECROW-ThinkNode-M6/variant.h
+++ b/variants/nrf52840/ELECROW-ThinkNode-M6/variant.h
@@ -40,7 +40,6 @@ extern "C" {
 #define NUM_ANALOG_OUTPUTS (0)

 // LEDs
-#define LED_BUILTIN -1
 #define LED_BLUE -1
 #define LED_CHARGE (12)
 #define LED_PAIRING (7)
--- a/variants/nrf52840/ME25LS01-4Y10TD/variant.h
+++ b/variants/nrf52840/ME25LS01-4Y10TD/variant.h
@@ -51,7 +51,6 @@ extern "C" {
 #define PIN_LED1 (32 + 7) // P1.07 Blue D2

 #define LED_PIN PIN_LED1
-#define LED_BUILTIN -1

 #define LED_BLUE -1
 #define LED_STATE_ON 1 // State when LED is lit
--- a/variants/nrf52840/ME25LS01-4Y10TD_e-ink/variant.h
+++ b/variants/nrf52840/ME25LS01-4Y10TD_e-ink/variant.h
@@ -51,7 +51,6 @@ extern "C" {
 #define PIN_LED1 (32 + 7) // P1.07 Blue D2

 #define LED_PIN PIN_LED1
-#define LED_BUILTIN -1

 #define LED_BLUE -1
 #define LED_STATE_ON 1 // State when LED is lit
--- a/variants/nrf52840/MS24SF1/variant.h
+++ b/variants/nrf52840/MS24SF1/variant.h
@@ -51,7 +51,6 @@ extern "C" {
 #define PIN_LED1 (-1)

 #define LED_PIN PIN_LED1
-#define LED_BUILTIN -1

 #define LED_BLUE -1
 #define LED_STATE_ON 1 // State when LED is lit
--- a/variants/nrf52840/MakePython_nRF52840_eink/variant.h
+++ b/variants/nrf52840/MakePython_nRF52840_eink/variant.h
@@ -29,7 +29,6 @@ extern "C" {
 #define PIN_LED1 (32 + 10) // LED        P1.15
 #define PIN_LED2 (-1)      //

-#define LED_BUILTIN PIN_LED1
 #define LED_CONN PIN_LED2

 #define LED_GREEN PIN_LED1
--- a/variants/nrf52840/MakePython_nRF52840_oled/variant.h
+++ b/variants/nrf52840/MakePython_nRF52840_oled/variant.h
@@ -29,7 +29,6 @@ extern "C" {
 #define PIN_LED1 (32 + 10) // LED        P1.15
 #define PIN_LED2 (-1)      //

-#define LED_BUILTIN PIN_LED1
 #define LED_CONN PIN_LED2

 #define LED_GREEN PIN_LED1
--- a/variants/nrf52840/TWC_mesh_v4/variant.h
+++ b/variants/nrf52840/TWC_mesh_v4/variant.h
@@ -34,7 +34,6 @@ extern "C" {
 // #define PIN_LED1 (32 + 9) Green
 // #define PIN_LED1 (0 + 12) Blue

-#define LED_BUILTIN PIN_LED1
 #define LED_CONN PIN_LED2

 #define LED_GREEN PIN_LED1
--- a/variants/nrf52840/canaryone/variant.h
+++ b/variants/nrf52840/canaryone/variant.h
@@ -52,7 +52,6 @@ extern "C" {

 #define LED_BLUE PIN_LED1

-#define LED_BUILTIN PIN_LED1
 #define LED_CONN PIN_LED3

 #define LED_STATE_ON 0 // State when LED is lit
--- a/variants/nrf52840/diy/nrf52_promicro_diy_tcxo/variant.h
+++ b/variants/nrf52840/diy/nrf52_promicro_diy_tcxo/variant.h
@@ -81,7 +81,6 @@ NRF52 PRO MICRO PIN ASSIGNMENT

 // LED
 #define PIN_LED1 (0 + 15) // P0.15
-#define LED_BUILTIN PIN_LED1
 // Actually red
 #define LED_BLUE PIN_LED1
 #define LED_STATE_ON 1 // State when LED is lit
--- a/variants/nrf52840/diy/seeed-xiao-nrf52840-wio-sx1262/variant.h
+++ b/variants/nrf52840/diy/seeed-xiao-nrf52840-wio-sx1262/variant.h
@@ -38,7 +38,6 @@ extern "C" {
 #define PIN_LED PIN_LED1
 #define LED_PWR (PINS_COUNT)

-#define LED_BUILTIN PIN_LED
 #define LED_STATE_ON 1 // State when LED is lit

 // XIAO Wio-SX1262 Shield User button
--- a/variants/nrf52840/feather_diy/variant.h
+++ b/variants/nrf52840/feather_diy/variant.h
@@ -49,8 +49,6 @@ extern "C" {
 #define PIN_LED1 (32 + 15) // P1.15 3
 #define PIN_LED2 (32 + 10) // P1.10 4

-#define LED_BUILTIN PIN_LED1
-
 #define LED_GREEN PIN_LED2 // Actually red
 #define LED_BLUE PIN_LED1

--- a/variants/nrf52840/gat562_mesh_trial_tracker/variant.h
+++ b/variants/nrf52840/gat562_mesh_trial_tracker/variant.h
@@ -48,7 +48,6 @@ extern "C" {
 #define PIN_LED1 (35)
 #define PIN_LED2 (36)

-#define LED_BUILTIN PIN_LED1
 #define LED_CONN PIN_LED2

 #define LED_GREEN PIN_LED1
--- a/variants/nrf52840/heltec_mesh_node_t114-inkhud/variant.h
+++ b/variants/nrf52840/heltec_mesh_node_t114-inkhud/variant.h
@@ -30,7 +30,6 @@ extern "C" {
 #define PIN_LED1 (32 + 3) // green (confirmed on 1.0 board)
 #define LED_BLUE PIN_LED1 // fake for bluefruit library
 #define LED_GREEN PIN_LED1
-#define LED_BUILTIN LED_GREEN
 #define LED_STATE_ON 0 // State when LED is lit

 #define HAS_NEOPIXEL                         // Enable the use of neopixels
--- a/variants/nrf52840/heltec_mesh_node_t114/variant.h
+++ b/variants/nrf52840/heltec_mesh_node_t114/variant.h
@@ -74,7 +74,6 @@ extern "C" {
 #define PIN_LED1 (32 + 3) // green (confirmed on 1.0 board)
 #define LED_BLUE PIN_LED1 // fake for bluefruit library
 #define LED_GREEN PIN_LED1
-#define LED_BUILTIN LED_GREEN
 #define LED_STATE_ON 0 // State when LED is lit

 #define HAS_NEOPIXEL                         // Enable the use of neopixels
--- a/variants/nrf52840/heltec_mesh_pocket/variant.h
+++ b/variants/nrf52840/heltec_mesh_pocket/variant.h
@@ -26,7 +26,6 @@ extern "C" {
 #define LED_RED PIN_LED1
 #define LED_BLUE PIN_LED1
 #define LED_GREEN PIN_LED1
-#define LED_BUILTIN LED_BLUE
 #define LED_CONN LED_BLUE
 #define LED_STATE_ON 0 // State when LED is lit

--- a/variants/nrf52840/heltec_mesh_solar/variant.h
+++ b/variants/nrf52840/heltec_mesh_solar/variant.h
@@ -42,7 +42,6 @@ extern "C" {
 #define PIN_LED1 (0 + 4)  // green (confirmed on 1.0 board)
 #define LED_BLUE PIN_LED1 // fake for bluefruit library
 #define LED_GREEN PIN_LED1
-#define LED_BUILTIN LED_GREEN
 #define LED_STATE_ON 0 // State when LED is lit

 #define HAS_NEOPIXEL                         // Enable the use of neopixels
--- a/variants/nrf52840/meshlink/variant.h
+++ b/variants/nrf52840/meshlink/variant.h
@@ -31,7 +31,6 @@ extern "C" {
 // LEDs
 #define PIN_LED1 (24) // Built in white led for status
 #define LED_BLUE PIN_LED1
-#define LED_BUILTIN PIN_LED1

 #define LED_STATE_ON 0 // State when LED is litted
 #define LED_INVERTED 1
--- a/variants/nrf52840/meshtiny/variant.h
+++ b/variants/nrf52840/meshtiny/variant.h
@@ -49,7 +49,6 @@ extern "C" {
 #define PIN_LED1 (35)
 #define PIN_LED2 (36)

-#define LED_BUILTIN PIN_LED1
 #define LED_CONN PIN_LED2

 #define LED_GREEN PIN_LED1
--- a/variants/nrf52840/monteops_hw1/variant.h
+++ b/variants/nrf52840/monteops_hw1/variant.h
@@ -52,7 +52,6 @@ extern "C" {
 #define PIN_LED1 (35)
 #define PIN_LED2 (36) // Connected to WWAN host LED (if present)

-#define LED_BUILTIN PIN_LED1
 #define LED_CONN PIN_LED2

 #define LED_GREEN PIN_LED1
--- a/variants/nrf52840/muzi_base/variant.h
+++ b/variants/nrf52840/muzi_base/variant.h
@@ -45,7 +45,6 @@ extern "C" {
 #define PIN_LED1 (32 + 3) // P1.03, Green
 #define PIN_LED2 (32 + 4) // P1.04, Blue

-#define LED_BUILTIN -1 // PIN_LED1
 #define LED_BLUE PIN_LED2
 #define LED_STATE_ON 0 // State when LED is lit

--- a/variants/nrf52840/nano-g2-ultra/variant.h
+++ b/variants/nrf52840/nano-g2-ultra/variant.h
@@ -50,7 +50,6 @@ extern "C" {
 #define LED_BLUE PIN_LED1
 #define LED_GREEN PIN_LED2

-#define LED_BUILTIN LED_BLUE
 #define LED_CONN PIN_GREEN

 #define LED_STATE_ON 0 // State when LED is lit
--- a/variants/nrf52840/r1-neo/variant.h
+++ b/variants/nrf52840/r1-neo/variant.h
@@ -47,7 +47,6 @@ extern "C" {
 #define PIN_LED1 (32 + 4) // P1.04 Controls Green LED
 #define PIN_LED2 (28)     // P0.28 Controls Blue LED

-#define LED_BUILTIN PIN_LED1
 #define LED_CONN PIN_LED2

 #define LED_GREEN PIN_LED1
--- a/variants/nrf52840/rak2560/variant.h
+++ b/variants/nrf52840/rak2560/variant.h
@@ -48,7 +48,6 @@ extern "C" {
 #define PIN_LED1 (35)
 #define PIN_LED2 (36)

-#define LED_BUILTIN PIN_LED1
 #define LED_CONN PIN_LED2

 #define LED_GREEN PIN_LED1
--- a/variants/nrf52840/rak3401_1watt/variant.h
+++ b/variants/nrf52840/rak3401_1watt/variant.h
@@ -47,7 +47,6 @@ extern "C" {
 #define PIN_LED1 (35)
 #define PIN_LED2 (36)

-#define LED_BUILTIN PIN_LED1
 #define LED_CONN PIN_LED2

 #define LED_GREEN PIN_LED1
--- a/variants/nrf52840/rak4631/variant.h
+++ b/variants/nrf52840/rak4631/variant.h
@@ -47,7 +47,6 @@ extern "C" {
 #define PIN_LED1 (35)
 #define PIN_LED2 (36)

-#define LED_BUILTIN PIN_LED1
 #define LED_CONN PIN_LED2

 #define LED_GREEN PIN_LED1
--- a/variants/nrf52840/rak4631_epaper/variant.h
+++ b/variants/nrf52840/rak4631_epaper/variant.h
@@ -47,7 +47,6 @@ extern "C" {
 #define PIN_LED1 (35)
 #define PIN_LED2 (36)

-#define LED_BUILTIN PIN_LED1
 #define LED_CONN PIN_LED2

 #define LED_GREEN PIN_LED1
--- a/variants/nrf52840/rak4631_epaper_onrxtx/variant.h
+++ b/variants/nrf52840/rak4631_epaper_onrxtx/variant.h
@@ -29,7 +29,6 @@ extern "C" {
 #define PIN_LED1 (35)
 #define PIN_LED2 (36)

-#define LED_BUILTIN PIN_LED1
 #define LED_CONN PIN_LED2

 #define LED_GREEN PIN_LED1
--- a/variants/nrf52840/rak4631_eth_gw/variant.h
+++ b/variants/nrf52840/rak4631_eth_gw/variant.h
@@ -47,7 +47,6 @@ extern "C" {
 #define PIN_LED1 (35)
 #define PIN_LED2 (36)

-#define LED_BUILTIN PIN_LED1
 #define LED_CONN PIN_LED2

 #define LED_GREEN PIN_LED1
--- a/variants/nrf52840/rak4631_nomadstar_meteor_pro/variant.h
+++ b/variants/nrf52840/rak4631_nomadstar_meteor_pro/variant.h
@@ -47,7 +47,6 @@ extern "C" {
 #define PIN_LED1 (35)
 #define PIN_LED2 (36)

-#define LED_BUILTIN PIN_LED1
 #define LED_CONN PIN_LED2

 #define LED_GREEN PIN_LED1
--- a/variants/nrf52840/rak_wismeshtag/variant.h
+++ b/variants/nrf52840/rak_wismeshtag/variant.h
@@ -47,7 +47,6 @@ extern "C" {
 #define PIN_LED1 (35)
 #define PIN_LED2 (36)

-#define LED_BUILTIN PIN_LED1
 #define LED_CONN PIN_LED2

 #define LED_GREEN PIN_LED1
--- a/variants/nrf52840/rak_wismeshtap/variant.h
+++ b/variants/nrf52840/rak_wismeshtap/variant.h
@@ -47,7 +47,6 @@ extern "C" {
 #define PIN_LED1 (35)
 #define PIN_LED2 (36)

-#define LED_BUILTIN PIN_LED1
 #define LED_CONN PIN_LED2

 #define LED_GREEN PIN_LED1
--- a/variants/nrf52840/seeed_solar_node/variant.h
+++ b/variants/nrf52840/seeed_solar_node/variant.h
@@ -23,7 +23,6 @@
 #define PIN_LED1 (12) // LED        P1.15
 #define PIN_LED2 (11) //

-#define LED_BUILTIN PIN_LED1
 #define LED_CONN PIN_LED2

 #define LED_GREEN PIN_LED1
--- a/variants/nrf52840/seeed_wio_tracker_L1/variant.h
+++ b/variants/nrf52840/seeed_wio_tracker_L1/variant.h
@@ -23,7 +23,6 @@
 #define PIN_LED1 (11) // LED        P1.15
 #define PIN_LED2 (12) //

-#define LED_BUILTIN PIN_LED1
 #define LED_CONN PIN_LED2

 #define LED_GREEN PIN_LED1
--- a/variants/nrf52840/seeed_wio_tracker_L1_eink/variant.h
+++ b/variants/nrf52840/seeed_wio_tracker_L1_eink/variant.h
@@ -23,7 +23,6 @@
 #define PIN_LED1 (11) // LED        P1.15
 #define PIN_LED2 (12) //

-#define LED_BUILTIN PIN_LED1
 #define LED_CONN PIN_LED2

 #define LED_GREEN PIN_LED1
--- a/variants/nrf52840/seeed_xiao_nrf52840_kit/variant.h
+++ b/variants/nrf52840/seeed_xiao_nrf52840_kit/variant.h
@@ -69,8 +69,6 @@ static const uint8_t A5 = PIN_A5;
 #define PIN_LED2 LED_BLUE
 #define PIN_LED3 LED_RED

-#define LED_BUILTIN LED_RED // LED_BUILTIN is used by framework-arduinoadafruitnrf52 to indicate flash writes
-
 #define LED_PWR LED_RED
 #define USER_LED LED_BLUE

--- a/variants/nrf52840/t-echo-lite/variant.h
+++ b/variants/nrf52840/t-echo-lite/variant.h
@@ -52,7 +52,6 @@ extern "C" {

 #define BLE_LED LED_BLUE
 #define BLE_LED_INVERTED 1
-#define LED_BUILTIN LED_GREEN
 #define LED_CONN LED_GREEN
 #define LED_STATE_ON 0 // State when LED is lit

--- a/variants/nrf52840/t-echo/variant.h
+++ b/variants/nrf52840/t-echo/variant.h
@@ -52,7 +52,6 @@ extern "C" {
 #define LED_BLUE PIN_LED1
 #define LED_GREEN PIN_LED2

-#define LED_BUILTIN LED_BLUE
 #define LED_CONN PIN_GREEN

 #define LED_STATE_ON 0 // State when LED is lit
--- a/variants/nrf52840/tracker-t1000-e/variant.h
+++ b/variants/nrf52840/tracker-t1000-e/variant.h
@@ -48,7 +48,6 @@ extern "C" {

 #define PIN_LED1 (0 + 24) // P0.24
 #define LED_PIN PIN_LED1
-#define LED_BUILTIN -1
 #define LED_BLUE -1    // Actually green
 #define LED_STATE_ON 1 // State when LED is lit

--- a/variants/nrf52840/wio-sdk-wm1110/variant.h
+++ b/variants/nrf52840/wio-sdk-wm1110/variant.h
@@ -58,8 +58,6 @@ extern "C" {
 #define PIN_LED1 (0 + 13) // P0.13
 #define PIN_LED2 (0 + 14) // P0.14

-#define LED_BUILTIN PIN_LED1
-
 #define LED_GREEN PIN_LED1
 #define LED_BLUE PIN_LED2 // Actually red

--- a/variants/nrf52840/wio-t1000-s/variant.h
+++ b/variants/nrf52840/wio-t1000-s/variant.h
@@ -48,7 +48,6 @@ extern "C" {

 #define PIN_LED1 (0 + 24) // P0.24
 #define LED_PIN PIN_LED1
-#define LED_BUILTIN -1
 #define LED_BLUE -1    // Actually green
 #define LED_STATE_ON 1 // State when LED is lit

--- a/variants/nrf52840/wio-tracker-wm1110/variant.h
+++ b/variants/nrf52840/wio-tracker-wm1110/variant.h
@@ -54,8 +54,6 @@ extern "C" {
 #define PIN_LED1 (0 + 6)      // P0.06
 #define PIN_LED2 (PINS_COUNT) // P0.14

-#define LED_BUILTIN PIN_LED1
-
 #define LED_GREEN PIN_LED1
 #define LED_BLUE PIN_LED2

--- a/variants/rp2040/challenger_2040_lora/pins_arduino.h
+++ b/variants/rp2040/challenger_2040_lora/pins_arduino.h
@@ -45,8 +45,6 @@
 #define SPI_HOWMANY (2u)
 #define WIRE_HOWMANY (1u)

-#define LED_BUILTIN PIN_LED
-
 static const uint8_t D0 = (16u);
 static const uint8_t D1 = (17u);
 static const uint8_t D2 = (20u);
--- a/variants/rp2040/rak11310/pins_arduino.h
+++ b/variants/rp2040/rak11310/pins_arduino.h
@@ -26,7 +26,6 @@ static const uint8_t A3 = PIN_A3;
 #define PIN_LED (23u)
 #define PIN_LED1 PIN_LED
 #define PIN_LED2 (24u)
-#define LED_BUILTIN PIN_LED

 #define ADC_RESOLUTION 12

--- a/variants/rp2040/rak11310/variant.h
+++ b/variants/rp2040/rak11310/variant.h
@@ -11,7 +11,7 @@
 #define I2C_SCL1 3

 #define LED_CONN PIN_LED2
-#define LED_PIN LED_BUILTIN
+#define LED_PIN PIN_LED
 #define ledOff(pin) pinMode(pin, INPUT)

 #define BUTTON_PIN 9
--- a/variants/rp2040/rpipicow/variant.h
+++ b/variants/rp2040/rpipicow/variant.h
@@ -19,8 +19,6 @@
 #define EXT_NOTIFY_OUT 22
 #define BUTTON_PIN 17

-#define LED_PIN LED_BUILTIN
-
 #define BATTERY_PIN 26
 // ratio of voltage divider = 3.0 (R17=200k, R18=100k)
 #define ADC_MULTIPLIER 3.1 // 3.0 + a bit for being optimistic
--- a/variants/rp2040/senselora_rp2040/pins_arduino.h
+++ b/variants/rp2040/senselora_rp2040/pins_arduino.h
@@ -13,7 +13,6 @@ static const uint8_t A3 = PIN_A3;
 // LEDs
 #define PIN_LED (23u)
 #define PIN_LED1 PIN_LED
-#define LED_BUILTIN PIN_LED

 #define ADC_RESOLUTION 12

--- a/variants/stm32/wio-e5/variant.h
+++ b/variants/stm32/wio-e5/variant.h
@@ -19,9 +19,4 @@ Do not expect a working Meshtastic device with this target.

 #define WIO_E5

-#if (defined(LED_BUILTIN) && LED_BUILTIN == PNUM_NOT_DEFINED)
-#undef LED_BUILTIN
-#define LED_BUILTIN (LED_PIN)
-#endif
-
 #endif
Author	SHA1	Message	Date
Jonathan Bennett	965ded88e1	Merge branch 'develop' into kill-led-builtin	2025-12-26 15:26:29 -06:00
Jonathan Bennett	e0a720d667	Merge branch 'develop' into kill-led-builtin	2025-12-21 23:23:45 -06:00
Jonathan Bennett	a14505cafa	Merge branch 'develop' into kill-led-builtin	2025-12-09 23:20:19 -06:00
Jonathan Bennett	2ae409ff8b	Merge branch 'develop' into kill-led-builtin	2025-12-08 17:16:10 -06:00
Jonathan Bennett	e500ae6415	LUD_BUILTIN workarounds	2025-12-08 17:14:43 -06:00
Jonathan Bennett	8fb0365833	Just set LED_BUILTIN universally to -1, as we don't use it.	2025-12-08 17:14:43 -06:00