rbxii3/firmware
1
0
Fork 0
mirror of https://github.com/meshtastic/firmware.git synced 2026-01-27 12:12:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Replace strcpy with strncpy and null termination (#9436)

Browse Source 
Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
This commit is contained in:
Keane
2026-01-26 15:32:03 -05:00
committed by GitHub
parent 3d58c6e916
commit 7efc3e3770
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/mqtt/MQTT.cpp
View File

@@ -475,8 +475,10 @@ bool MQTT::publish(const char *topic, const char *payload, bool retained)
if (moduleConfig.mqtt.proxy_to_client_enabled) {
meshtastic_MqttClientProxyMessage *msg = mqttClientProxyMessagePool.allocZeroed();
msg->which_payload_variant = meshtastic_MqttClientProxyMessage_text_tag;
strcpy(msg->topic, topic);
strcpy(msg->payload_variant.text, payload);
strncpy(msg->topic, topic, sizeof(msg->topic));
msg->topic[sizeof(msg->topic) - 1] = '\0';
strncpy(msg->payload_variant.text, payload, sizeof(msg->payload_variant.text));
msg->payload_variant.text[sizeof(msg->payload_variant.text) - 1] = '\0';
msg->retained = retained;
service->sendMqttMessageToClientProxy(msg);
return true;