InkHUD refactoring (#6216)

* chore: todo.txt
* chore: comments
* fix: no fast refresh on VME290
Reverts a line of code which was accidentally committed
* refactor: god class
Divide the behavior from the old WindowManager class into several subclasses which each have a clear role.
* refactor: cppcheck medium warnings
Enough to pass github CI for now
* refactor: updateType selection
* refactor: don't use a setter for the shared AppletFonts
* fix: update prioritization
forceUpdate calls weren't being prioritized
* refactor: remove unhelpful logging
getTimeString is used for parsing our own time, but also the timestamps of messages. The "one time only" log printing will likely fire in unhelpful situations.
* fix: " "
* refactor: get rid of types.h file for enums
* Keep that sneaky todo file out of commits

src/graphics/niche/InkHUD/Applets/User/AllMessage/AllMessageApplet.cpp

@@ -41,14 +41,12 @@ int InkHUD::AllMessageApplet::onReceiveTextMessage(const meshtastic_MeshPacket *
 
 void InkHUD::AllMessageApplet::onRender()
 {
-    setFont(fontSmall);
-
     // Find newest message, regardless of whether DM or broadcast
     MessageStore::Message *message;
-    if (latestMessage.wasBroadcast)
-        message = &latestMessage.broadcast;
+    if (latestMessage->wasBroadcast)
+        message = &latestMessage->broadcast;
     else
-        message = &latestMessage.dm;
+        message = &latestMessage->dm;
 
     // Short circuit: no text message
     if (!message->sender) {

src/graphics/niche/InkHUD/Applets/User/DM/DMApplet.cpp

@@ -44,10 +44,8 @@ int InkHUD::DMApplet::onReceiveTextMessage(const meshtastic_MeshPacket *p)
 
 void InkHUD::DMApplet::onRender()
 {
-    setFont(fontSmall);
-
     // Abort if no text message
-    if (!latestMessage.dm.sender) {
+    if (!latestMessage->dm.sender) {
         printAt(X(0.5), Y(0.5), "No DMs", CENTER, MIDDLE);
         return;
     }
@@ -63,7 +61,7 @@ void InkHUD::DMApplet::onRender()
 
     // RX Time
     // - if valid
-    std::string timeString = getTimeString(latestMessage.dm.timestamp);
+    std::string timeString = getTimeString(latestMessage->dm.timestamp);
     if (timeString.length() > 0) {
         header += timeString;
         header += ": ";
@@ -72,14 +70,14 @@ void InkHUD::DMApplet::onRender()
     // Sender's id
     // - shortname, if available, or
     // - node id
-    meshtastic_NodeInfoLite *sender = nodeDB->getMeshNode(latestMessage.dm.sender);
+    meshtastic_NodeInfoLite *sender = nodeDB->getMeshNode(latestMessage->dm.sender);
     if (sender && sender->has_user) {
         header += sender->user.short_name;
         header += " (";
         header += sender->user.long_name;
         header += ")";
     } else
-        header += hexifyNodeNum(latestMessage.dm.sender);
+        header += hexifyNodeNum(latestMessage->dm.sender);
 
     // Draw a "standard" applet header
     drawHeader(header);
@@ -103,14 +101,14 @@ void InkHUD::DMApplet::onRender()
 
     // Determine size if printed large
     setFont(fontLarge);
-    uint32_t textHeight = getWrappedTextHeight(0, width(), latestMessage.dm.text);
+    uint32_t textHeight = getWrappedTextHeight(0, width(), latestMessage->dm.text);
 
     // If too large, swap to small font
     if (textHeight + textTop > (uint32_t)height()) // (compare signed and unsigned)
         setFont(fontSmall);
 
     // Print text
-    printWrapped(0, textTop, width(), latestMessage.dm.text);
+    printWrapped(0, textTop, width(), latestMessage->dm.text);
 }
 
 // Don't show notifications for direct messages when our applet is displayed

src/graphics/niche/InkHUD/Applets/User/Positions/PositionsApplet.h

@@ -29,13 +29,13 @@ class PositionsApplet : public MapApplet, public SinglePortModule
   protected:
     ProcessMessage handleReceived(const meshtastic_MeshPacket &mp) override;
 
-    NodeNum lastFrom; // Sender of most recent (non-local) position packet
-    float lastLat;
-    float lastLng;
-    float lastHopsAway;
+    NodeNum lastFrom = 0; // Sender of most recent (non-local) position packet
+    float lastLat = 0.0;
+    float lastLng = 0.0;
+    float lastHopsAway = 0;
 
-    float ourLastLat; // Info about the most recent (non-local) position packet
-    float ourLastLng; // Info about most recent *local* position
+    float ourLastLat = 0.0; // Info about the most recent (non-local) position packet
+    float ourLastLng = 0.0; // Info about most recent *local* position
 };
 
 } // namespace NicheGraphics::InkHUD

src/graphics/niche/InkHUD/Applets/User/RecentsList/RecentsListApplet.cpp

@@ -122,7 +122,7 @@ bool InkHUD::RecentsListApplet::isActive(uint32_t seenAtMs)
     uint32_t now = millis();
     uint32_t secsAgo = (now - seenAtMs) / 1000UL; // millis() overflow safe
 
-    return (secsAgo < settings.recentlyActiveSeconds);
+    return (secsAgo < settings->recentlyActiveSeconds);
 }
 
 // Text to be shown at top of applet
@@ -134,7 +134,7 @@ std::string InkHUD::RecentsListApplet::getHeaderText()
 
     // Print the length of our "Recents" time-window
     text += "Last ";
-    text += to_string(settings.recentlyActiveSeconds / 60);
+    text += to_string(settings->recentlyActiveSeconds / 60);
     text += " mins";
 
     // Print the node count

src/graphics/niche/InkHUD/Applets/User/ThreadedMessage/ThreadedMessageApplet.cpp

@@ -23,8 +23,6 @@ InkHUD::ThreadedMessageApplet::ThreadedMessageApplet(uint8_t channelIndex) : cha
 
 void InkHUD::ThreadedMessageApplet::onRender()
 {
-    setFont(fontSmall);
-
     // =============
     // Draw a header
     // =============

src/graphics/niche/InkHUD/Applets/User/ThreadedMessage/ThreadedMessageApplet.h

@@ -33,7 +33,7 @@ class Applet;
 class ThreadedMessageApplet : public Applet
 {
   public:
-    ThreadedMessageApplet(uint8_t channelIndex);
+    explicit ThreadedMessageApplet(uint8_t channelIndex);
     ThreadedMessageApplet() = delete;
 
     void onRender() override;