Revert "add a .clang-format file (#9154)" (#9172)

I thought git would be smart enough to understand all the whitespace changes but even with all the flags I know to make it ignore theses it still blows up if there are identical changes on both sides.

I have a solution but it require creating a new commit at the merge base for each conflicting PR and merging it into develop.

I don't think blowing up all PRs is worth for now, maybe if we can coordinate this for V3 let's say.

This reverts commit 0d11331d18.

src/mesh/CryptoEngine.h

@@ -9,10 +9,10 @@
 extern concurrency::Lock *cryptLock;
 
 struct CryptoKey {
-  uint8_t bytes[32];
+    uint8_t bytes[32];
 
-  /// # of bytes, or -1 to mean "invalid key - do not use"
-  int8_t length;
+    /// # of bytes, or -1 to mean "invalid key - do not use"
+    int8_t length;
 };
 
 /**
@@ -23,74 +23,75 @@ struct CryptoKey {
 #define MAX_BLOCKSIZE 256
 #define TEST_CURVE25519_FIELD_OPS // Exposes Curve25519::isWeakPoint() for testing keys
 
-class CryptoEngine {
-public:
+class CryptoEngine
+{
+  public:
 #if !(MESHTASTIC_EXCLUDE_PKI)
-  uint8_t public_key[32] = {0};
+    uint8_t public_key[32] = {0};
 #endif
 
-  virtual ~CryptoEngine() {}
+    virtual ~CryptoEngine() {}
 #if !(MESHTASTIC_EXCLUDE_PKI)
 #if !(MESHTASTIC_EXCLUDE_PKI_KEYGEN)
-  virtual void generateKeyPair(uint8_t *pubKey, uint8_t *privKey);
-  virtual bool regeneratePublicKey(uint8_t *pubKey, uint8_t *privKey);
+    virtual void generateKeyPair(uint8_t *pubKey, uint8_t *privKey);
+    virtual bool regeneratePublicKey(uint8_t *pubKey, uint8_t *privKey);
 
 #endif
-  void clearKeys();
-  void setDHPrivateKey(uint8_t *_private_key);
-  virtual bool encryptCurve25519(uint32_t toNode, uint32_t fromNode, meshtastic_UserLite_public_key_t remotePublic, uint64_t packetNum,
-                                 size_t numBytes, const uint8_t *bytes, uint8_t *bytesOut);
-  virtual bool decryptCurve25519(uint32_t fromNode, meshtastic_UserLite_public_key_t remotePublic, uint64_t packetNum, size_t numBytes,
-                                 const uint8_t *bytes, uint8_t *bytesOut);
-  virtual bool setDHPublicKey(uint8_t *publicKey);
-  virtual void hash(uint8_t *bytes, size_t numBytes);
+    void clearKeys();
+    void setDHPrivateKey(uint8_t *_private_key);
+    virtual bool encryptCurve25519(uint32_t toNode, uint32_t fromNode, meshtastic_UserLite_public_key_t remotePublic,
+                                   uint64_t packetNum, size_t numBytes, const uint8_t *bytes, uint8_t *bytesOut);
+    virtual bool decryptCurve25519(uint32_t fromNode, meshtastic_UserLite_public_key_t remotePublic, uint64_t packetNum,
+                                   size_t numBytes, const uint8_t *bytes, uint8_t *bytesOut);
+    virtual bool setDHPublicKey(uint8_t *publicKey);
+    virtual void hash(uint8_t *bytes, size_t numBytes);
 
-  virtual void aesSetKey(const uint8_t *key, size_t key_len);
+    virtual void aesSetKey(const uint8_t *key, size_t key_len);
 
-  virtual void aesEncrypt(uint8_t *in, uint8_t *out);
-  AESSmall256 *aes = NULL;
+    virtual void aesEncrypt(uint8_t *in, uint8_t *out);
+    AESSmall256 *aes = NULL;
 
 #endif
 
-  /**
-   * Set the key used for encrypt, decrypt.
-   *
-   * As a special case: If all bytes are zero, we assume _no encryption_ and send all data in cleartext.
-   *
-   * @param numBytes must be 16 (AES128), 32 (AES256) or 0 (no crypt)
-   * @param bytes a _static_ buffer that will remain valid for the life of this crypto instance (i.e. this class will
-   * cache the provided pointer)
-   */
-  virtual void setKey(const CryptoKey &k);
+    /**
+     * Set the key used for encrypt, decrypt.
+     *
+     * As a special case: If all bytes are zero, we assume _no encryption_ and send all data in cleartext.
+     *
+     * @param numBytes must be 16 (AES128), 32 (AES256) or 0 (no crypt)
+     * @param bytes a _static_ buffer that will remain valid for the life of this crypto instance (i.e. this class will cache the
+     * provided pointer)
+     */
+    virtual void setKey(const CryptoKey &k);
 
-  /**
-   * Encrypt a packet
-   *
-   * @param bytes is updated in place
-   */
-  virtual void encryptPacket(uint32_t fromNode, uint64_t packetId, size_t numBytes, uint8_t *bytes);
-  virtual void decrypt(uint32_t fromNode, uint64_t packetId, size_t numBytes, uint8_t *bytes);
-  virtual void encryptAESCtr(CryptoKey key, uint8_t *nonce, size_t numBytes, uint8_t *bytes);
+    /**
+     * Encrypt a packet
+     *
+     * @param bytes is updated in place
+     */
+    virtual void encryptPacket(uint32_t fromNode, uint64_t packetId, size_t numBytes, uint8_t *bytes);
+    virtual void decrypt(uint32_t fromNode, uint64_t packetId, size_t numBytes, uint8_t *bytes);
+    virtual void encryptAESCtr(CryptoKey key, uint8_t *nonce, size_t numBytes, uint8_t *bytes);
 #ifndef PIO_UNIT_TESTING
-protected:
+  protected:
 #endif
-  /** Our per packet nonce */
-  uint8_t nonce[16] = {0};
-  CryptoKey key = {};
-  CTRCommon *ctr = NULL;
+    /** Our per packet nonce */
+    uint8_t nonce[16] = {0};
+    CryptoKey key = {};
+    CTRCommon *ctr = NULL;
 #if !(MESHTASTIC_EXCLUDE_PKI)
-  uint8_t shared_key[32] = {0};
-  uint8_t private_key[32] = {0};
+    uint8_t shared_key[32] = {0};
+    uint8_t private_key[32] = {0};
 #endif
-  /**
-   * Init our 128 bit nonce for a new packet
-   *
-   * The NONCE is constructed by concatenating (from MSB to LSB):
-   * a 64 bit packet number (stored in little endian order)
-   * a 32 bit sending node number (stored in little endian order)
-   * a 32 bit block counter (starts at zero)
-   */
-  void initNonce(uint32_t fromNode, uint64_t packetId, uint32_t extraNonce = 0);
+    /**
+     * Init our 128 bit nonce for a new packet
+     *
+     * The NONCE is constructed by concatenating (from MSB to LSB):
+     * a 64 bit packet number (stored in little endian order)
+     * a 32 bit sending node number (stored in little endian order)
+     * a 32 bit block counter (starts at zero)
+     */
+    void initNonce(uint32_t fromNode, uint64_t packetId, uint32_t extraNonce = 0);
 };
 
 extern CryptoEngine *crypto;