move nodeinfo messages into new plugin system

src/plugins/NodeInfoPlugin.cpp

@@ -0,0 +1,39 @@
+#include "NodeInfoPlugin.h"
+#include "MeshService.h"
+#include "NodeDB.h"
+#include "RTC.h"
+#include "Router.h"
+#include "configuration.h"
+#include "main.h"
+
+NodeInfoPlugin nodeInfoPlugin;
+
+bool NodeInfoPlugin::handleReceivedProtobuf(const MeshPacket &mp, const User &p)
+{
+    // FIXME - we currently update NodeInfo data in the DB only if the message was a broadcast or destined to us
+    // it would be better to update even if the message was destined to others.
+
+    nodeDB.updateUser(mp.from, p);
+
+    bool wasBroadcast = mp.to == NODENUM_BROADCAST;
+
+    // Show new nodes on LCD screen
+    if (wasBroadcast) {
+        String lcd = String("Joined: ") + p.long_name + "\n";
+        screen->print(lcd.c_str());
+    }
+
+    return false; // Let others look at this message also if they want
+}
+
+void NodeInfoPlugin::sendOurNodeInfo(NodeNum dest, bool wantReplies)
+{
+    User &u = owner;
+
+    DEBUG_MSG("sending owner %s/%s/%s\n", u.id, u.long_name, u.short_name);
+    MeshPacket *p = allocForSending(u);
+    p->to = dest;
+    p->decoded.want_response = wantReplies;
+
+    service.sendToMesh(p);
+}

src/plugins/NodeInfoPlugin.h

@@ -0,0 +1,29 @@
+#pragma once
+#include "ProtobufPlugin.h"
+
+/**
+ * NodeInfo plugin for sending/receiving NodeInfos into the mesh
+ */
+class NodeInfoPlugin : public ProtobufPlugin<User>
+{
+  public:
+    /** Constructor
+     * name is for debugging output
+     */
+    NodeInfoPlugin() : ProtobufPlugin("nodeinfo", PortNum_NODEINFO_APP, User_fields) {}
+
+    /**
+     * Send our NodeInfo into the mesh
+     */
+    void sendOurNodeInfo(NodeNum dest = NODENUM_BROADCAST, bool wantReplies = false);
+
+  protected:
+
+    /** Called to handle a particular incoming message
+
+    @return true if you've guaranteed you've handled this message and no other handlers should be considered for it
+    */
+    virtual bool handleReceivedProtobuf(const MeshPacket &mp, const User &p);
+};
+
+extern NodeInfoPlugin nodeInfoPlugin;

src/plugins/PositionPlugin.cpp

@@ -12,6 +12,17 @@ bool PositionPlugin::handleReceivedProtobuf(const MeshPacket &mp, const Position
     // FIXME - we currently update position data in the DB only if the message was a broadcast or destined to us
     // it would be better to update even if the message was destined to others.
 
+    DEBUG_MSG("handled incoming position time=%u\n", p.time);
+    if (p.time) {
+        struct timeval tv;
+        uint32_t secs = p.time;
+
+        tv.tv_sec = secs;
+        tv.tv_usec = 0;
+
+        perhapsSetRTC(RTCQualityFromNet, &tv);
+    }
+
     nodeDB.updatePosition(mp.from, p);
 
     return false; // Let others look at this message also if they want

src/plugins/PositionPlugin.h

@@ -1,3 +1,4 @@
+#pragma once
 #include "ProtobufPlugin.h"
 
 /**

src/plugins/TextMessagePlugin.h

@@ -1,3 +1,4 @@
+#pragma once
 #include "MeshPlugin.h"
 #include "Observer.h"