rbxii3/firmware
1
0
Fork 0
mirror of https://github.com/meshtastic/firmware.git synced 2025-12-21 18:22:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

note about security

Browse Source
This commit is contained in:
Kevin Hester
2021-04-05 08:56:11 +08:00
parent 3cd64bb8b5
commit 8ef36bcc9c
2 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
proto

Submodule proto updated: 9c16118e59...3252ed0f13

4
src/mesh/MeshPlugin.cpp
View File

@@ -142,6 +142,10 @@ void MeshPlugin::callPlugins(const MeshPacket &mp)
} else { } else {
// No one wanted to reply to this requst, tell the requster that happened // No one wanted to reply to this requst, tell the requster that happened
DEBUG_MSG("No one responded, send a nak\n"); DEBUG_MSG("No one responded, send a nak\n");
// SECURITY NOTE! I considered sending back a different error code if we didn't find the psk (i.e. !isDecoded)
// but opted NOT TO. Because it is not a good idea to let remote nodes 'probe' to find out which PSKs were "good" vs
// bad.
routingPlugin->sendAckNak(Routing_Error_NO_RESPONSE, getFrom(&mp), mp.id, mp.channel); routingPlugin->sendAckNak(Routing_Error_NO_RESPONSE, getFrom(&mp), mp.id, mp.channel);
} }
} }