From 82cf2bf16a620a23849c0e73fdb27427a61b6a85 Mon Sep 17 00:00:00 2001 From: Jorropo Date: Fri, 26 Dec 2025 23:26:48 +0100 Subject: [PATCH 01/15] action: skip trying to comment binary size change results if it is not a PR (#9033) * action: skip trying to comment binary size change results if it is not a PR * action: fix halucinations in the clanker's code * action: cleanup one line --------- Co-authored-by: Ben Meadors Co-authored-by: Austin --- .github/workflows/main_matrix.yml | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/.github/workflows/main_matrix.yml b/.github/workflows/main_matrix.yml index 8a25829e4..7280f9df4 100644 --- a/.github/workflows/main_matrix.yml +++ b/.github/workflows/main_matrix.yml @@ -240,6 +240,7 @@ jobs: needs: [build] steps: - uses: actions/checkout@v6 + if: github.event_name == 'pull_request_target' with: filter: blob:none # means we download all the git history but none of the commit (except ones with checkout like the head) fetch-depth: 0 @@ -253,18 +254,20 @@ jobs: uses: actions/upload-artifact@v6 id: upload-manifest with: - name: manifests-all + name: manifests-${{ github.sha }} overwrite: true - path: | - manifests-new/*.mt.json + path: manifests-new/*.mt.json - name: Find the merge base + if: github.event_name == 'pull_request_target' run: echo "MERGE_BASE=$(git merge-base "origin/$base" "$head")" >> $GITHUB_ENV env: base: ${{ github.base_ref }} - head: ${{ github.head_ref }} + head: ${{ github.sha }} - name: Download the old manifests - run: gh run download -R ${{ github.repository }} --commit ${{ env.MERGE_BASE }} --name manifests-all --dir manifest-old/ + if: github.event_name == 'pull_request_target' + run: gh run download -R ${{ github.repository }} --name manifests-${{ env.MERGE_BASE }} --dir manifest-old/ - name: Do scan and post comment + if: github.event_name == 'pull_request_target' run: python3 bin/shame.py ${{ github.event.pull_request.number }} manifests-old/ manifests-new/ release-artifacts: From 29c5713a7e72e48e9c6994bfce9f4bd08832d758 Mon Sep 17 00:00:00 2001 From: Austin Date: Fri, 26 Dec 2025 18:04:43 -0500 Subject: [PATCH 02/15] Correctly set type for event_mode max() position threshold (#9083) Fixes EVENT_MODE firmware builds --- src/modules/PositionModule.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/PositionModule.h b/src/modules/PositionModule.h index 4a2415058..32e499531 100644 --- a/src/modules/PositionModule.h +++ b/src/modules/PositionModule.h @@ -69,7 +69,7 @@ class PositionModule : public ProtobufModule, private concu // In event mode we want to prevent excessive position broadcasts // we set the minimum interval to 5m const uint32_t minimumTimeThreshold = - max(300000, Default::getConfiguredOrDefaultMs(config.position.broadcast_smart_minimum_interval_secs, 30)); + max(uint32_t(300000), Default::getConfiguredOrDefaultMs(config.position.broadcast_smart_minimum_interval_secs, 30)); #else const uint32_t minimumTimeThreshold = Default::getConfiguredOrDefaultMs(config.position.broadcast_smart_minimum_interval_secs, 30); From db2224ed0e4fcc178ef6265d525e88694e2c6a31 Mon Sep 17 00:00:00 2001 From: Austin Date: Fri, 26 Dec 2025 18:45:43 -0500 Subject: [PATCH 03/15] pioarduino .gitignore (#9085) I'm already going insane! --- .gitignore | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.gitignore b/.gitignore index cc742c6c1..06e8c472f 100644 --- a/.gitignore +++ b/.gitignore @@ -41,3 +41,12 @@ src/mesh/raspihttp/private_key.pem # Ignore logo (set at build time with platformio-custom.py) data/boot/logo.* + +# pioarduino platform +managed_components/* +arduino-lib-builder* +dependencies.lock +idf_component.yml +CMakeLists.txt +sdkconfig.* +.dummy/* From 3473c32e8139aa9c5b72ccb81eaca4ede7cbf4da Mon Sep 17 00:00:00 2001 From: Austin Date: Fri, 26 Dec 2025 19:55:47 -0500 Subject: [PATCH 04/15] Fix PR#8061 SensorLib nRF ThinkNode M-series (#9084) --- variants/nrf52840/ELECROW-ThinkNode-M3/platformio.ini | 4 ++-- variants/nrf52840/ELECROW-ThinkNode-M3/variant.h | 3 ++- variants/nrf52840/ELECROW-ThinkNode-M6/platformio.ini | 4 ++-- variants/nrf52840/ELECROW-ThinkNode-M6/variant.h | 3 ++- 4 files changed, 8 insertions(+), 6 deletions(-) diff --git a/variants/nrf52840/ELECROW-ThinkNode-M3/platformio.ini b/variants/nrf52840/ELECROW-ThinkNode-M3/platformio.ini index 7dadc27ee..0ed46896f 100644 --- a/variants/nrf52840/ELECROW-ThinkNode-M3/platformio.ini +++ b/variants/nrf52840/ELECROW-ThinkNode-M3/platformio.ini @@ -15,5 +15,5 @@ lib_deps = ${nrf52840_base.lib_deps} # renovate: datasource=custom.pio depName=nRF52_PWM packageName=khoih-prog/library/nRF52_PWM khoih-prog/nRF52_PWM@1.0.1 - # renovate: datasource=custom.pio depName=PCF8563 packageName=lewisxhe/library/PCF8563_Library - lewisxhe/PCF8563_Library@1.0.1 + ; # renovate: datasource=custom.pio depName=SensorLib packageName=lewisxhe/library/SensorLib + ; lewisxhe/SensorLib@0.3.3 diff --git a/variants/nrf52840/ELECROW-ThinkNode-M3/variant.h b/variants/nrf52840/ELECROW-ThinkNode-M3/variant.h index a27a344d2..29a6c85fd 100644 --- a/variants/nrf52840/ELECROW-ThinkNode-M3/variant.h +++ b/variants/nrf52840/ELECROW-ThinkNode-M3/variant.h @@ -114,7 +114,8 @@ extern "C" { #define LR11X0_DIO_AS_RF_SWITCH // PCF8563 RTC Module -#define PCF8563_RTC 0x51 +// REVISIT https://github.com/meshtastic/firmware/pull/9084 +// #define PCF8563_RTC 0x51 #ifdef __cplusplus } diff --git a/variants/nrf52840/ELECROW-ThinkNode-M6/platformio.ini b/variants/nrf52840/ELECROW-ThinkNode-M6/platformio.ini index 8f1a660cd..18108df83 100644 --- a/variants/nrf52840/ELECROW-ThinkNode-M6/platformio.ini +++ b/variants/nrf52840/ELECROW-ThinkNode-M6/platformio.ini @@ -12,5 +12,5 @@ build_flags = ${nrf52840_base.build_flags} build_src_filter = ${nrf52_base.build_src_filter} +<../variants/nrf52840/ELECROW-ThinkNode-M6> lib_deps = ${nrf52840_base.lib_deps} - # renovate: datasource=custom.pio depName=PCF8563 packageName=lewisxhe/library/PCF8563_Library - lewisxhe/PCF8563_Library@1.0.1 + ; # renovate: datasource=custom.pio depName=SensorLib packageName=lewisxhe/library/SensorLib + ; lewisxhe/SensorLib@0.3.3 diff --git a/variants/nrf52840/ELECROW-ThinkNode-M6/variant.h b/variants/nrf52840/ELECROW-ThinkNode-M6/variant.h index d30b88d66..7fe9f719a 100644 --- a/variants/nrf52840/ELECROW-ThinkNode-M6/variant.h +++ b/variants/nrf52840/ELECROW-ThinkNode-M6/variant.h @@ -119,7 +119,8 @@ static const uint8_t A0 = PIN_A0; #define PIN_SERIAL2_TX (24) // PCF8563 RTC Module -#define PCF8563_RTC 0x51 +// REVISIT https://github.com/meshtastic/firmware/pull/9084 +// #define PCF8563_RTC 0x51 // SPI #define SPI_INTERFACES_COUNT 1 From 7dd9c8b2233afc54f31738399bb7cb8aafc31ca5 Mon Sep 17 00:00:00 2001 From: Jorropo Date: Sat, 27 Dec 2025 04:04:18 +0100 Subject: [PATCH 05/15] pass GH_TOKEN to shame's gh run download step (#9087) --- .github/workflows/main_matrix.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/main_matrix.yml b/.github/workflows/main_matrix.yml index 7280f9df4..1d86520d0 100644 --- a/.github/workflows/main_matrix.yml +++ b/.github/workflows/main_matrix.yml @@ -265,7 +265,11 @@ jobs: head: ${{ github.sha }} - name: Download the old manifests if: github.event_name == 'pull_request_target' - run: gh run download -R ${{ github.repository }} --name manifests-${{ env.MERGE_BASE }} --dir manifest-old/ + run: gh run download -R "$repo" --name "manifests-$merge_base" --dir manifest-old/ + env: + GH_TOKEN: ${{ github.token }} + merge_base: ${{ env.MERGE_BASE }} + repo: ${{ github.repository }} - name: Do scan and post comment if: github.event_name == 'pull_request_target' run: python3 bin/shame.py ${{ github.event.pull_request.number }} manifests-old/ manifests-new/ From cbd40faa897a9d4879e79b25497e4a30e6f70899 Mon Sep 17 00:00:00 2001 From: Ben Meadors Date: Sat, 20 Dec 2025 14:09:05 -0600 Subject: [PATCH 06/15] Fix -ota.zip in manifest and build output --- bin/build-nrf52.sh | 3 ++- bin/platformio-custom.py | 7 ++++++- src/modules/PositionModule.cpp | 2 ++ 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/bin/build-nrf52.sh b/bin/build-nrf52.sh index e3a421865..edcc2add2 100755 --- a/bin/build-nrf52.sh +++ b/bin/build-nrf52.sh @@ -21,13 +21,14 @@ rm -f $BUILDDIR/firmware* export APP_VERSION=$VERSION basename=firmware-$1-$VERSION +ota_basename=${basename}-ota pio run --environment $1 -t mtjson # -v cp $BUILDDIR/$basename.elf $OUTDIR/$basename.elf echo "Copying NRF52 dfu (OTA) file" -cp $BUILDDIR/$basename.zip $OUTDIR/$basename.zip +cp $BUILDDIR/$basename.zip $OUTDIR/$ota_basename.zip echo "Copying NRF52 UF2 file" cp $BUILDDIR/$basename.uf2 $OUTDIR/$basename.uf2 diff --git a/bin/platformio-custom.py b/bin/platformio-custom.py index 3fdbffb70..b6560f35b 100644 --- a/bin/platformio-custom.py +++ b/bin/platformio-custom.py @@ -17,6 +17,8 @@ lfsbin = f"{progname.replace('firmware-', 'littlefs-')}.bin" def manifest_gather(source, target, env): out = [] + board_platform = env.BoardConfig().get("platform") + needs_ota_suffix = board_platform == "nordicnrf52" check_paths = [ progname, f"{progname}.elf", @@ -32,8 +34,11 @@ def manifest_gather(source, target, env): for p in check_paths: f = env.File(env.subst(f"$BUILD_DIR/{p}")) if f.exists(): + manifest_name = p + if needs_ota_suffix and p == f"{progname}.zip": + manifest_name = f"{progname}-ota.zip" d = { - "name": p, + "name": manifest_name, "md5": f.get_content_hash(), # Returns MD5 hash "bytes": f.get_size() # Returns file size in bytes } diff --git a/src/modules/PositionModule.cpp b/src/modules/PositionModule.cpp index 0fa09df74..f7116e701 100644 --- a/src/modules/PositionModule.cpp +++ b/src/modules/PositionModule.cpp @@ -429,7 +429,9 @@ int32_t PositionModule::runOnce() if (lastGpsSend == 0 || msSinceLastSend >= intervalMs) { if (waitingForFreshPosition) { +#ifdef GPS_DEBUG LOG_DEBUG("Skip initial position send; no fresh position since boot"); +#endif } else if (nodeDB->hasValidPosition(node)) { lastGpsSend = now; From 514f8590feb6dfefcc90e7eb0d982f7b266da3fd Mon Sep 17 00:00:00 2001 From: Ben Meadors Date: Sat, 20 Dec 2025 14:10:02 -0600 Subject: [PATCH 07/15] Revert "Automated version bumps (#9025)" This reverts commit 1021d967dadcc24135aeab88f81ba30dc1c023cd. --- bin/org.meshtastic.meshtasticd.metainfo.xml | 3 --- debian/changelog | 6 ------ version.properties | 2 +- 3 files changed, 1 insertion(+), 10 deletions(-) diff --git a/bin/org.meshtastic.meshtasticd.metainfo.xml b/bin/org.meshtastic.meshtasticd.metainfo.xml index 5779167ab..140ac3e2a 100644 --- a/bin/org.meshtastic.meshtasticd.metainfo.xml +++ b/bin/org.meshtastic.meshtasticd.metainfo.xml @@ -87,9 +87,6 @@ - - https://github.com/meshtastic/firmware/releases?q=tag%3Av2.7.18 - https://github.com/meshtastic/firmware/releases?q=tag%3Av2.7.17 diff --git a/debian/changelog b/debian/changelog index ccaffa3cf..b9212c1be 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,9 +1,3 @@ -meshtasticd (2.7.18.0) unstable; urgency=medium - - * Version 2.7.18 - - -- GitHub Actions Sat, 20 Dec 2025 15:47:25 +0000 - meshtasticd (2.7.17.0) unstable; urgency=medium * Version 2.7.17 diff --git a/version.properties b/version.properties index 0a028eff0..8e40687e9 100644 --- a/version.properties +++ b/version.properties @@ -1,4 +1,4 @@ [VERSION] major = 2 minor = 7 -build = 18 +build = 17 From b88a8bf9686990a02c2e1c0b25e06e833b46188f Mon Sep 17 00:00:00 2001 From: Jonathan Bennett Date: Tue, 23 Dec 2025 07:48:55 -0600 Subject: [PATCH 08/15] In statusLEDModule, also detect isCharging (#9050) --- src/modules/StatusLEDModule.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/StatusLEDModule.cpp b/src/modules/StatusLEDModule.cpp index 04cd7326f..8738c16ca 100644 --- a/src/modules/StatusLEDModule.cpp +++ b/src/modules/StatusLEDModule.cpp @@ -20,7 +20,7 @@ int StatusLEDModule::handleStatusUpdate(const meshtastic::Status *arg) switch (arg->getStatusType()) { case STATUS_TYPE_POWER: { meshtastic::PowerStatus *powerStatus = (meshtastic::PowerStatus *)arg; - if (powerStatus->getHasUSB()) { + if (powerStatus->getHasUSB() || powerStatus->getIsCharging()) { power_state = charging; if (powerStatus->getBatteryChargePercent() >= 100) { power_state = charged; From 2b977b483000a2dc4cce17192e477c902fb5a823 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Tue, 23 Dec 2025 18:55:37 -0600 Subject: [PATCH 09/15] Update meshtastic-esp8266-oled-ssd1306 digest to b34c681 (#9062) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> --- platformio.ini | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/platformio.ini b/platformio.ini index 4fa7acd66..2b52ce3a5 100644 --- a/platformio.ini +++ b/platformio.ini @@ -64,7 +64,7 @@ monitor_speed = 115200 monitor_filters = direct lib_deps = # renovate: datasource=git-refs depName=meshtastic-esp8266-oled-ssd1306 packageName=https://github.com/meshtastic/esp8266-oled-ssd1306 gitBranch=master - https://github.com/meshtastic/esp8266-oled-ssd1306/archive/2887bf4a19f64d92c984dcc8fd5ca7429e425e4a.zip + https://github.com/meshtastic/esp8266-oled-ssd1306/archive/b34c6817c25d6faabb3a8a162b5d14fb75395433.zip # renovate: datasource=git-refs depName=meshtastic-OneButton packageName=https://github.com/meshtastic/OneButton gitBranch=master https://github.com/meshtastic/OneButton/archive/fa352d668c53f290cfa480a5f79ad422cd828c70.zip # renovate: datasource=git-refs depName=meshtastic-arduino-fsm packageName=https://github.com/meshtastic/arduino-fsm gitBranch=master From 69c3c0151fd292200bf2bb26443255bd92a47905 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Tue, 23 Dec 2025 18:55:54 -0600 Subject: [PATCH 10/15] Upgrade trunk (#9047) Co-authored-by: vidplace7 <1779290+vidplace7@users.noreply.github.com> --- .trunk/trunk.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.trunk/trunk.yaml b/.trunk/trunk.yaml index c20066f7f..5075bb749 100644 --- a/.trunk/trunk.yaml +++ b/.trunk/trunk.yaml @@ -9,9 +9,9 @@ plugins: lint: enabled: - checkov@3.2.495 - - renovate@42.64.1 + - renovate@42.66.0 - prettier@3.7.4 - - trufflehog@3.92.3 + - trufflehog@3.92.4 - yamllint@1.37.1 - bandit@1.9.2 - trivy@0.68.2 From e899e84ef9505565fc9d237f97186a0106d420fd Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed, 24 Dec 2025 05:20:22 -0600 Subject: [PATCH 11/15] Upgrade trunk (#9067) Co-authored-by: vidplace7 <1779290+vidplace7@users.noreply.github.com> --- .trunk/trunk.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.trunk/trunk.yaml b/.trunk/trunk.yaml index 5075bb749..093c4c2a2 100644 --- a/.trunk/trunk.yaml +++ b/.trunk/trunk.yaml @@ -9,7 +9,7 @@ plugins: lint: enabled: - checkov@3.2.495 - - renovate@42.66.0 + - renovate@42.66.2 - prettier@3.7.4 - trufflehog@3.92.4 - yamllint@1.37.1 From 4fbe5356ca84bc336e9ed024bf53998a88de40fa Mon Sep 17 00:00:00 2001 From: Jonathan Bennett Date: Wed, 24 Dec 2025 07:48:14 -0600 Subject: [PATCH 12/15] M6 shutdown and LEDs work (#9065) Co-authored-by: Ben Meadors --- src/mesh/NodeDB.cpp | 3 ++- .../nrf52840/ELECROW-ThinkNode-M6/variant.cpp | 27 +++++++++++++++++++ .../nrf52840/ELECROW-ThinkNode-M6/variant.h | 4 ++- 3 files changed, 32 insertions(+), 2 deletions(-) diff --git a/src/mesh/NodeDB.cpp b/src/mesh/NodeDB.cpp index 2d4bad854..9052ee17c 100644 --- a/src/mesh/NodeDB.cpp +++ b/src/mesh/NodeDB.cpp @@ -805,7 +805,8 @@ void NodeDB::installDefaultModuleConfig() moduleConfig.external_notification.output_ms = 500; moduleConfig.external_notification.nag_timeout = 2; #endif -#if defined(RAK4630) || defined(RAK11310) || defined(RAK3312) || defined(MUZI_BASE) || defined(ELECROW_ThinkNode_M3) +#if defined(RAK4630) || defined(RAK11310) || defined(RAK3312) || defined(MUZI_BASE) || defined(ELECROW_ThinkNode_M3) || \ + defined(ELECROW_ThinkNode_M6) // Default to PIN_LED2 for external notification output (LED color depends on device variant) moduleConfig.external_notification.enabled = true; moduleConfig.external_notification.output = PIN_LED2; diff --git a/variants/nrf52840/ELECROW-ThinkNode-M6/variant.cpp b/variants/nrf52840/ELECROW-ThinkNode-M6/variant.cpp index 09872d409..9c7b521ef 100644 --- a/variants/nrf52840/ELECROW-ThinkNode-M6/variant.cpp +++ b/variants/nrf52840/ELECROW-ThinkNode-M6/variant.cpp @@ -41,3 +41,30 @@ void initVariant() pinMode(VDD_FLASH_EN, OUTPUT); digitalWrite(VDD_FLASH_EN, HIGH); } + +// called from main-nrf52.cpp during the cpuDeepSleep() function +void variant_shutdown() +{ + // This sets the pin to OUTPUT and LOW for the pins *not* in the if block. + for (int pin = 0; pin < 48; pin++) { + if (pin == PIN_GPS_EN || pin == ADC_CTRL || pin == PIN_BUTTON1 || pin == PIN_SPI_MISO || pin == PIN_SPI_MOSI || + pin == PIN_SPI_SCK) { + continue; + } + pinMode(pin, OUTPUT); + digitalWrite(pin, LOW); + if (pin >= 32) { + NRF_P1->DIRCLR = (1 << (pin - 32)); + } else { + NRF_GPIO->DIRCLR = (1 << pin); + } + } + + digitalWrite(PIN_GPS_EN, LOW); + digitalWrite(ADC_CTRL, LOW); + // digitalWrite(RTC_POWER, LOW); + + nrf_gpio_cfg_input(PIN_BUTTON1, NRF_GPIO_PIN_PULLUP); // Configure the pin to be woken up as an input + nrf_gpio_pin_sense_t sense1 = NRF_GPIO_PIN_SENSE_LOW; + nrf_gpio_cfg_sense_set(PIN_BUTTON1, sense1); +} diff --git a/variants/nrf52840/ELECROW-ThinkNode-M6/variant.h b/variants/nrf52840/ELECROW-ThinkNode-M6/variant.h index 7fe9f719a..984f967d8 100644 --- a/variants/nrf52840/ELECROW-ThinkNode-M6/variant.h +++ b/variants/nrf52840/ELECROW-ThinkNode-M6/variant.h @@ -44,8 +44,10 @@ extern "C" { #define LED_BLUE -1 #define LED_CHARGE (12) #define LED_PAIRING (7) +#define PIN_LED2 LED_PAIRING -#define LED_STATE_ON 1 +#define LED_STATE_ON HIGH +#define LED_STATE_OFF LOW // USB power detection #define EXT_PWR_DETECT (13) From 9e215213a76b0e3d07d1851cc996896badc6e28e Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu, 25 Dec 2025 06:34:38 -0600 Subject: [PATCH 13/15] Upgrade trunk (#9072) Co-authored-by: vidplace7 <1779290+vidplace7@users.noreply.github.com> --- .trunk/trunk.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.trunk/trunk.yaml b/.trunk/trunk.yaml index 093c4c2a2..211f3912b 100644 --- a/.trunk/trunk.yaml +++ b/.trunk/trunk.yaml @@ -9,7 +9,7 @@ plugins: lint: enabled: - checkov@3.2.495 - - renovate@42.66.2 + - renovate@42.66.4 - prettier@3.7.4 - trufflehog@3.92.4 - yamllint@1.37.1 From ac937766cd9b0d353d9c192766a40fb8cc31177c Mon Sep 17 00:00:00 2001 From: Jonathan Bennett Date: Fri, 26 Dec 2025 14:33:17 -0600 Subject: [PATCH 14/15] In autoconf, don't probe Wire unless i2c device is set (#9081) Found another bit of code that crashes my desktop, by probing the wrong i2c bus. --- src/platform/portduino/PortduinoGlue.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/platform/portduino/PortduinoGlue.cpp b/src/platform/portduino/PortduinoGlue.cpp index dab9e8d8c..4722a66e5 100644 --- a/src/platform/portduino/PortduinoGlue.cpp +++ b/src/platform/portduino/PortduinoGlue.cpp @@ -279,7 +279,7 @@ void portduinoSetup() // RAK6421-13300-S1:aabbcc123456:5ba85807d92138b7519cfb60460573af:3061e8d8 // :mac address :<16 random unique bytes in hexidecimal> : crc32 // crc32 is calculated on the eeprom string up to but not including the final colon - if (strlen(autoconf_product) < 6) { + if (strlen(autoconf_product) < 6 && portduino_config.i2cdev != "") { try { char *mac_start = nullptr; char *devID_start = nullptr; @@ -869,4 +869,4 @@ void readGPIOFromYaml(YAML::Node sourceNode, pinMapping &destPin, int pinDefault destPin.line = destPin.pin; destPin.gpiochip = portduino_config.lora_default_gpiochip; } -} \ No newline at end of file +} From cf03caff10c0158344974d12a3a4e30c699ba73a Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Fri, 26 Dec 2025 17:45:57 -0600 Subject: [PATCH 15/15] Upgrade trunk (#9076) Co-authored-by: vidplace7 <1779290+vidplace7@users.noreply.github.com> --- .trunk/trunk.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.trunk/trunk.yaml b/.trunk/trunk.yaml index 211f3912b..3656ae32c 100644 --- a/.trunk/trunk.yaml +++ b/.trunk/trunk.yaml @@ -9,7 +9,7 @@ plugins: lint: enabled: - checkov@3.2.495 - - renovate@42.66.4 + - renovate@42.66.8 - prettier@3.7.4 - trufflehog@3.92.4 - yamllint@1.37.1