From 325f7d2e55cd43187d51593669c1a76c8dd05072 Mon Sep 17 00:00:00 2001 From: Jonathan Bennett Date: Sun, 4 Jan 2026 21:11:47 -0600 Subject: [PATCH] Don't process packet when decoding fails --- src/modules/Native/StoreForwardPlusPlus.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/modules/Native/StoreForwardPlusPlus.cpp b/src/modules/Native/StoreForwardPlusPlus.cpp index 65d4ecbe9..550fd9c8a 100644 --- a/src/modules/Native/StoreForwardPlusPlus.cpp +++ b/src/modules/Native/StoreForwardPlusPlus.cpp @@ -389,8 +389,10 @@ ProcessMessage StoreForwardPlusPlusModule::handleReceived(const meshtastic_MeshP } else if (mp.decoded.portnum == portduino_config.sfpp_steal_port ? meshtastic_PortNum_TEXT_MESSAGE_COMPRESSED_APP : meshtastic_PortNum_STORE_FORWARD_PLUSPLUS_APP) { meshtastic_StoreForwardPlusPlus scratch; - pb_decode_from_bytes(mp.decoded.payload.bytes, mp.decoded.payload.size, meshtastic_StoreForwardPlusPlus_fields, &scratch); - handleReceivedProtobuf(mp, &scratch); + if (pb_decode_from_bytes(mp.decoded.payload.bytes, mp.decoded.payload.size, meshtastic_StoreForwardPlusPlus_fields, + &scratch)) { + handleReceivedProtobuf(mp, &scratch); + } return ProcessMessage::CONTINUE; } return ProcessMessage::CONTINUE;